opentelemetry-instrumentation-aiohttp-client: add ability to capture custom headers #3988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nitpick: might change get_custom_header_attributes to get_sanatized_custom_header_attributes, but otherwise looks good to me! |
JWinermaSplunk
approved these changes
Dec 4, 2025
herin049
force-pushed
the
feature/aiohttp-client-custom-headers
branch
from
9870a3d to
99f9f39
Compare
Contributor
Author
I was considering adding even more context to this function name e.g. making it |
xrmx
reviewed
Dec 22, 2025
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py
xrmx
reviewed
Dec 22, 2025
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py
xrmx
approved these changes
Dec 22, 2025
github-project-automation
bot
moved this from Ready for review
to Done
in @xrmx's Python PR digest
herin049
added a commit
to herin049/opentelemetry-python-contrib
that referenced
this pull request
Dec 22, 2025
…custom headers (open-telemetry#3988) * opentelemetry-instrumentation-aiohttp-client: add support to capture custom headers * update unit tests * update CHANGELOG.md * add 'get_custom_header_attributes' helper to opentelemetry-util-http * fix formatting issues * fix CHANGELOG.md format * Update instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py * Update instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to capture custom client headers in the
opentelemetry-instrumentation-aiohttp-clientlibrary. These changes implement #3962 for theaiohttpHTTP client library.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Basic set of unit tests have been added.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.